[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <7743b3e7-da5f-667d-9222-7ecab5a20876@huawei.com>
Date: Tue, 23 Jul 2019 09:41:17 +0800
From: Hanjun Guo <guohanjun@...wei.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
<linux-acpi@...r.kernel.org>
CC: Will Deacon <will@...nel.org>, Sudeep Holla <sudeep.holla@....com>,
Catalin Marinas <catalin.marinas@....com>,
Robin Murphy <robin.murphy@....com>,
Kefeng Wang <wangkefeng.wang@...wei.com>,
LKML <linux-kernel@...r.kernel.org>,
LAKML <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] ACPI/IORT: Rename arm_smmu_v3_set_proximity() 'node'
local variable
On 2019/7/23 0:14, Lorenzo Pieralisi wrote:
> Commit 36a2ba07757d ("ACPI/IORT: Reject platform device creation on NUMA
> node mapping failure") introduced a local variable 'node' in
> arm_smmu_v3_set_proximity() that shadows the struct acpi_iort_node
> pointer function parameter.
>
> Execution was unaffected but it is prone to errors and can lead
> to subtle bugs.
>
> Rename the local variable to prevent any issue.
>
> Reported-by: Will Deacon <will@...nel.org>
> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@....com>
> Cc: Will Deacon <will@...nel.org>
> Cc: Hanjun Guo <guohanjun@...wei.com>
> Cc: Sudeep Holla <sudeep.holla@....com>
> Cc: Catalin Marinas <catalin.marinas@....com>
> Cc: Robin Murphy <robin.murphy@....com>
> Cc: Kefeng Wang <wangkefeng.wang@...wei.com>
> ---
> drivers/acpi/arm64/iort.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Hanjun Guo <guohanjun@...wei.com>
Powered by blists - more mailing lists