[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <d3137d6b-8bf8-4da6-9da7-a42b8bc68fbd@roeck-us.net>
Date: Mon, 22 Jul 2019 18:56:13 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Vijay Khemka <vijaykhemka@...com>
Cc: Jean Delvare <jdelvare@...e.com>, Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Joel Stanley <joel@....id.au>,
Andrew Jeffery <andrew@...id.au>,
"linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
"openbmc @ lists . ozlabs . org" <openbmc@...ts.ozlabs.org>,
Sai Dasari <sdasari@...com>
Subject: Re: [PATCH] dt-bindings: hwmon: Add binding for pxe1610
On 7/22/19 5:12 PM, Vijay Khemka wrote:
>
>
> On 7/22/19, 1:06 PM, "Guenter Roeck" <groeck7@...il.com on behalf of linux@...ck-us.net> wrote:
>
> On Mon, Jul 22, 2019 at 12:24:48PM -0700, Vijay Khemka wrote:
> > Added new DT binding document for Infineon PXE1610 devices.
> >
> > Signed-off-by: Vijay Khemka <vijaykhemka@...com>
> > ---
> > .../devicetree/bindings/hwmon/pxe1610.txt | 15 +++++++++++++++
> > 1 file changed, 15 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/hwmon/pxe1610.txt
> >
> > diff --git a/Documentation/devicetree/bindings/hwmon/pxe1610.txt b/Documentation/devicetree/bindings/hwmon/pxe1610.txt
> > new file mode 100644
> > index 000000000000..635daf4955db
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/hwmon/pxe1610.txt
> > @@ -0,0 +1,15 @@
> > +pxe1610 properties
> > +
> > +Required properties:
> > +- compatible: Must be one of the following:
> > + - "infineon,pxe1610" for pxe1610
> > + - "infineon,pxe1110" for pxe1610
> > + - "infineon,pxm1310" for pxm1310
> > +- reg: I2C address
> > +
> > +Example:
> > +
> > +vr@48 {
> > + compatible = "infineon,pxe1610";
> > + reg = <0x48>;
> > +};
>
> Wouldn't it be better to add this to
> ./Documentation/devicetree/bindings/trivial-devices.txt ?
> Sure, I didn't know about this file. I will add and send another patch. It is
> Documentation/devicetree/bindings/trivial-devices.yaml. How do I abandon
> this patch or just leave it.
>
When you send v2, just add the device to the trivial-devices file instead
and describe the differences to v1 (ie this patch).
Guenter
Powered by blists - more mailing lists