linux-kernel - Re: [PATCH] mm/hotplug: remove unneeded return for void function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <287d5f14-2400-dc7f-7c90-11fa52d6a49d@redhat.com>
Date:   Tue, 23 Jul 2019 15:13:45 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Weitao Hou <houweitaoo@...il.com>, akpm@...ux-foundation.org,
        osalvador@...e.de, mhocko@...e.com, pasha.tatashin@...een.com,
        dan.j.williams@...el.com
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/hotplug: remove unneeded return for void function

On 23.07.19 15:08, Weitao Hou wrote:
> return is unneeded in void function
> 
> Signed-off-by: Weitao Hou <houweitaoo@...il.com>
> ---
>  mm/memory_hotplug.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 2a9bbddb0e55..c73f09913165 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -132,7 +132,6 @@ static void release_memory_resource(struct resource *res)
>  		return;
>  	release_resource(res);
>  	kfree(res);
> -	return;
>  }
>  
>  #ifdef CONFIG_MEMORY_HOTPLUG_SPARSE
> @@ -979,7 +978,6 @@ static void rollback_node_hotadd(int nid)
>  	arch_refresh_nodedata(nid, NULL);
>  	free_percpu(pgdat->per_cpu_nodestats);
>  	arch_free_nodedata(pgdat);
> -	return;
>  }
>  
>  
> 

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 

Thanks,

David / dhildenb