linux-kernel - Re: [PATCH 0/2] Remove blk_mq_sched_started

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <864e671d-06ba-9689-9caa-8435cde1c860@kernel.dk>
Date:   Mon, 22 Jul 2019 20:17:51 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Marcos Paulo de Souza <marcos.souza.org@...il.com>,
        linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
        hare@...e.com
Subject: Re: [PATCH 0/2] Remove blk_mq_sched_started_request function

On 7/22/19 8:14 PM, Marcos Paulo de Souza wrote:
> While inspecting the queue_rq calling sites, I verified that
> blk_mq_start_request calls blk_mq_sched_started_request, and this function
> checks if the elevator of the current request implements the started_request,
> but currently none of the available IO schedulers do.
> 
> So, let's remove blk_mq_sched_started_request along with started_request, which
> is member of the elevator_mq_ops struct.

Looks fine to me as it's unused, but please fold the two patches. Makes no
sense to split that into two separate patches.

-- 
Jens Axboe