linux-kernel - Re: [RFC] ARM: bcm2835: register dmabounce on devices hooked to main interconnect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190723163433.GA2234@lst.de>
Date:   Tue, 23 Jul 2019 18:34:33 +0200
From:   Christoph Hellwig <hch@....de>
To:     Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        bcm-kernel-feedback-list@...adcom.com,
        Eric Anholt <eric@...olt.net>,
        Stefan Wahren <wahrenst@....net>, mbrugger@...e.com,
        hch@....de, Russell King <linux@...linux.org.uk>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-rpi-kernel@...ts.infradead.org
Subject: Re: [RFC] ARM: bcm2835: register dmabounce on devices hooked to
 main interconnect

> +static int bcm2835_needs_bounce(struct device *dev, dma_addr_t dma_addr, size_t size)

Too long line..

> +void __init bcm2835_init_early(void)
> +{
> +	if(of_machine_is_compatible("brcm,bcm2711"))

Odd formatting.

Otherwise this looks good to me.