linux-kernel - Re: [PATCH RESEND] scsi: megaraid_sas: fix panic on loading firmware crashdump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 23 Jul 2019 23:46:25 +0530
From:   Sumit Saxena <sumit.saxena@...adcom.com>
To:     Junxiao Bi <junxiao.bi@...cle.com>
Cc:     "PDL,MEGARAIDLINUX" <megaraidlinux.pdl@...adcom.com>,
        Linux SCSI List <linux-scsi@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Kashyap Desai <kashyap.desai@...adcom.com>,
        Shivasharan Srikanteshwara 
        <shivasharan.srikanteshwara@...adcom.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
Subject: Re: [PATCH RESEND] scsi: megaraid_sas: fix panic on loading firmware crashdump

On Mon, Jul 22, 2019 at 9:45 PM Junxiao Bi <junxiao.bi@...cle.com> wrote:
>
> While loading fw crashdump in function fw_crash_buffer_show(),
> left bytes in one dma chunk was not checked, if copying size
> over it, overflow access will cause kernel panic.
>
> Signed-off-by: Junxiao Bi <junxiao.bi@...cle.com>
Acked-by: Sumit Saxena <sumit.saxena@...adcom.com>
> ---
>  drivers/scsi/megaraid/megaraid_sas_base.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
> index 80ab9700f1de..3eef0858fa8e 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -3153,6 +3153,7 @@ fw_crash_buffer_show(struct device *cdev,
>                 (struct megasas_instance *) shost->hostdata;
>         u32 size;
>         unsigned long dmachunk = CRASH_DMA_BUF_SIZE;
> +       unsigned long chunk_left_bytes;
>         unsigned long src_addr;
>         unsigned long flags;
>         u32 buff_offset;
> @@ -3176,6 +3177,8 @@ fw_crash_buffer_show(struct device *cdev,
>         }
>
>         size = (instance->fw_crash_buffer_size * dmachunk) - buff_offset;
> +       chunk_left_bytes = dmachunk - (buff_offset % dmachunk);
> +       size = (size > chunk_left_bytes) ? chunk_left_bytes : size;
>         size = (size >= PAGE_SIZE) ? (PAGE_SIZE - 1) : size;
>
>         src_addr = (unsigned long)instance->crash_buf[buff_offset / dmachunk] +
> --
> 2.17.1
>