| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAHp75Vf8EUKLSWoEshU_VogBDym_oco_kj3AhfT=9KqtaGba3Q@mail.gmail.com>
Date: Tue, 23 Jul 2019 21:31:54 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Stephen Boyd <swboyd@...omium.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Rob Herring <robh@...nel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
Javier Martinez Canillas <javierm@...hat.com>,
Andrzej Hajda <a.hajda@...sung.com>,
Mark Brown <broonie@...nel.org>,
Russell King - ARM Linux <linux@...linux.org.uk>,
Marek Szyprowski <m.szyprowski@...sung.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@...el.com>
Subject: Re: [PATCH v4 2/3] treewide: Remove dev_err() usage after platform_get_irq()
On Tue, Jul 23, 2019 at 9:16 PM Stephen Boyd <swboyd@...omium.org> wrote:
>
> We don't need dev_err() messages when platform_get_irq() fails now that
> platform_get_irq() prints an error message itself when something goes
> wrong. Let's remove these prints with a simple semantic patch.
>
> // <smpl>
> @@
> expression ret;
> struct platform_device *E;
> @@
>
> ret =
> (
> platform_get_irq(E, ...)
> |
> platform_get_irq_byname(E, ...)
> );
>
> if ( \( ret < 0 \| ret <= 0 \) )
> {
> (
> -if (ret != -EPROBE_DEFER)
> -{ ...
> -dev_err(...);
> -... }
> |
> ...
> -dev_err(...);
> )
> ...
> }
> // </smpl>
>
Can you teach it to remove curly braces when it's appropriate? (see
below for examples)
> drivers/i2c/busses/i2c-cht-wc.c | 1 -
> drivers/mfd/intel_soc_pmic_bxtwc.c | 1 -
> drivers/pinctrl/intel/pinctrl-cherryview.c | 1 -
> drivers/pinctrl/intel/pinctrl-intel.c | 1 -
> drivers/platform/x86/intel_bxtwc_tmu.c | 1 -
> drivers/platform/x86/intel_int0002_vgpio.c | 1 -
> drivers/platform/x86/intel_pmc_ipc.c | 1 -
Can you split this on per subsystem level?
Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
after addressing above.
> diff --git a/drivers/i2c/busses/i2c-cht-wc.c b/drivers/i2c/busses/i2c-cht-wc.c
> index 66af44bfa67d..02f9f3eccbed 100644
> --- a/drivers/i2c/busses/i2c-cht-wc.c
> +++ b/drivers/i2c/busses/i2c-cht-wc.c
> @@ -270,7 +270,6 @@ static int cht_wc_i2c_adap_i2c_probe(struct platform_device *pdev)
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
> - dev_err(&pdev->dev, "Error missing irq resource\n");
> return -EINVAL;
> }
No need for curly braces.
> diff --git a/drivers/mfd/intel_soc_pmic_bxtwc.c b/drivers/mfd/intel_soc_pmic_bxtwc.c
> index 6310c3bdb991..3bbd16628581 100644
> --- a/drivers/mfd/intel_soc_pmic_bxtwc.c
> +++ b/drivers/mfd/intel_soc_pmic_bxtwc.c
> @@ -451,7 +451,6 @@ static int bxtwc_probe(struct platform_device *pdev)
>
> ret = platform_get_irq(pdev, 0);
> if (ret < 0) {
> - dev_err(&pdev->dev, "Invalid IRQ\n");
> return ret;
> }
> pmic->irq = ret;
Ditto.
> diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c
> index 03ec7a5d9d0b..98f8b276db51 100644
> --- a/drivers/pinctrl/intel/pinctrl-cherryview.c
> +++ b/drivers/pinctrl/intel/pinctrl-cherryview.c
> @@ -1704,7 +1704,6 @@ static int chv_pinctrl_probe(struct platform_device *pdev)
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
> - dev_err(&pdev->dev, "failed to get interrupt number\n");
> return irq;
> }
>
> diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c
> index a18d6eefe672..f37c4a7ff313 100644
> --- a/drivers/pinctrl/intel/pinctrl-intel.c
> +++ b/drivers/pinctrl/intel/pinctrl-intel.c
> @@ -1355,7 +1355,6 @@ static int intel_pinctrl_probe(struct platform_device *pdev,
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
> - dev_err(&pdev->dev, "failed to get interrupt number\n");
> return irq;
> }
>
Ditto.
> diff --git a/drivers/platform/x86/intel_bxtwc_tmu.c b/drivers/platform/x86/intel_bxtwc_tmu.c
> index 951c105bafc1..fe609b937def 100644
> --- a/drivers/platform/x86/intel_bxtwc_tmu.c
> +++ b/drivers/platform/x86/intel_bxtwc_tmu.c
> @@ -62,7 +62,6 @@ static int bxt_wcove_tmu_probe(struct platform_device *pdev)
> irq = platform_get_irq(pdev, 0);
>
> if (irq < 0) {
> - dev_err(&pdev->dev, "invalid irq %d\n", irq);
> return irq;
> }
>
> diff --git a/drivers/platform/x86/intel_int0002_vgpio.c b/drivers/platform/x86/intel_int0002_vgpio.c
> index d9542c661ddc..cca021e42baa 100644
> --- a/drivers/platform/x86/intel_int0002_vgpio.c
> +++ b/drivers/platform/x86/intel_int0002_vgpio.c
> @@ -167,7 +167,6 @@ static int int0002_probe(struct platform_device *pdev)
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
> - dev_err(dev, "Error getting IRQ: %d\n", irq);
> return irq;
> }
>
> diff --git a/drivers/platform/x86/intel_pmc_ipc.c b/drivers/platform/x86/intel_pmc_ipc.c
> index 55037ff258f8..b5b9baf3e898 100644
> --- a/drivers/platform/x86/intel_pmc_ipc.c
> +++ b/drivers/platform/x86/intel_pmc_ipc.c
> @@ -937,7 +937,6 @@ static int ipc_plat_probe(struct platform_device *pdev)
>
> ipcdev.irq = platform_get_irq(pdev, 0);
> if (ipcdev.irq < 0) {
> - dev_err(&pdev->dev, "Failed to get irq\n");
> return -EINVAL;
> }
>
Ditto.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists