linux-kernel - Re: [PATCH] leds: is31fl319x: simplify getting the adapter of a client

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 23 Jul 2019 21:02:21 +0200
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>,
        linux-i2c@...r.kernel.org
Cc:     Pavel Machek <pavel@....cz>, Dan Murphy <dmurphy@...com>,
        linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] leds: is31fl319x: simplify getting the adapter of a
 client

Hi Wolfram,

Thank you for the patch.

On 7/22/19 8:14 PM, Wolfram Sang wrote:
> We have a dedicated pointer for that, so use it. Much easier to read and
> less computation involved.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> ---
>  drivers/leds/leds-is31fl319x.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/leds/leds-is31fl319x.c b/drivers/leds/leds-is31fl319x.c
> index 2d077b8edd0e..ca6634b8683c 100644
> --- a/drivers/leds/leds-is31fl319x.c
> +++ b/drivers/leds/leds-is31fl319x.c
> @@ -333,12 +333,11 @@ static int is31fl319x_probe(struct i2c_client *client,
>  {
>  	struct is31fl319x_chip *is31;
>  	struct device *dev = &client->dev;
> -	struct i2c_adapter *adapter = to_i2c_adapter(dev->parent);
>  	int err;
>  	int i = 0;
>  	u32 aggregated_led_microamp = IS31FL319X_CURRENT_MAX;
>  
> -	if (!i2c_check_functionality(adapter, I2C_FUNC_I2C))
> +	if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C))
>  		return -EIO;
>  
>  	is31 = devm_kzalloc(&client->dev, sizeof(*is31), GFP_KERNEL);
> 

Applied.

-- 
Best regards,
Jacek Anaszewski