linux-kernel - Re: [PATCH net-next 06/11] net: hns3: modify firmware version display format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4c4ce27c9a9372340c0e2b0f654b3fb9cd85b3e4.camel@mellanox.com>
Date:   Wed, 24 Jul 2019 18:34:50 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "tanhuazhong@...wei.com" <tanhuazhong@...wei.com>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "lipeng321@...wei.com" <lipeng321@...wei.com>,
        "yisen.zhuang@...wei.com" <yisen.zhuang@...wei.com>,
        "salil.mehta@...wei.com" <salil.mehta@...wei.com>,
        "linuxarm@...wei.com" <linuxarm@...wei.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "moyufeng@...wei.com" <moyufeng@...wei.com>
Subject: Re: [PATCH net-next 06/11] net: hns3: modify firmware version display
 format

On Wed, 2019-07-24 at 11:18 +0800, Huazhong Tan wrote:
> From: Yufeng Mo <moyufeng@...wei.com>
> 
> This patch modifies firmware version display format in
> hclge(vf)_cmd_init() and hns3_get_drvinfo(). Also, adds
> some optimizations for firmware version display format.
> 
> Signed-off-by: Yufeng Mo <moyufeng@...wei.com>
> Signed-off-by: Peng Li <lipeng321@...wei.com>
> Signed-off-by: Huazhong Tan <tanhuazhong@...wei.com>
> ---
>  drivers/net/ethernet/hisilicon/hns3/hnae3.h              |  9
> +++++++++
>  drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c       | 15
> +++++++++++++--
>  drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c   | 10
> +++++++++-
>  drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd.c | 11
> +++++++++--
>  4 files changed, 40 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hnae3.h
> b/drivers/net/ethernet/hisilicon/hns3/hnae3.h
> index 48c7b70..a4624db 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hnae3.h
> +++ b/drivers/net/ethernet/hisilicon/hns3/hnae3.h
> @@ -179,6 +179,15 @@ struct hnae3_vector_info {
>  #define HNAE3_RING_GL_RX 0
>  #define HNAE3_RING_GL_TX 1
>  
> +#define HNAE3_FW_VERSION_BYTE3_SHIFT	24
> +#define HNAE3_FW_VERSION_BYTE3_MASK	GENMASK(31, 24)
> +#define HNAE3_FW_VERSION_BYTE2_SHIFT	16
> +#define HNAE3_FW_VERSION_BYTE2_MASK	GENMASK(23, 16)
> +#define HNAE3_FW_VERSION_BYTE1_SHIFT	8
> +#define HNAE3_FW_VERSION_BYTE1_MASK	GENMASK(15, 8)
> +#define HNAE3_FW_VERSION_BYTE0_SHIFT	0
> +#define HNAE3_FW_VERSION_BYTE0_MASK	GENMASK(7, 0)
> +
>  struct hnae3_ring_chain_node {
>  	struct hnae3_ring_chain_node *next;
>  	u32 tqp_index;
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
> b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
> index 5bff98a..e71c92b 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
> @@ -527,6 +527,7 @@ static void hns3_get_drvinfo(struct net_device
> *netdev,
>  {
>  	struct hns3_nic_priv *priv = netdev_priv(netdev);
>  	struct hnae3_handle *h = priv->ae_handle;
> +	u32 fw_version;
>  
>  	if (!h->ae_algo->ops->get_fw_version) {
>  		netdev_err(netdev, "could not get fw version!\n");
> @@ -545,8 +546,18 @@ static void hns3_get_drvinfo(struct net_device
> *netdev,
>  		sizeof(drvinfo->bus_info));
>  	drvinfo->bus_info[ETHTOOL_BUSINFO_LEN - 1] = '\0';
>  
> -	snprintf(drvinfo->fw_version, sizeof(drvinfo->fw_version),
> "0x%08x",
> -		 priv->ae_handle->ae_algo->ops->get_fw_version(h));
> +	fw_version = priv->ae_handle->ae_algo->ops->get_fw_version(h);
> +
> +	snprintf(drvinfo->fw_version, sizeof(drvinfo->fw_version),
> +		 "%lu.%lu.%lu.%lu",
> +		 hnae3_get_field(fw_version,
> HNAE3_FW_VERSION_BYTE3_MASK,
> +				 HNAE3_FW_VERSION_BYTE3_SHIFT),
> +		 hnae3_get_field(fw_version,
> HNAE3_FW_VERSION_BYTE2_MASK,
> +				 HNAE3_FW_VERSION_BYTE2_SHIFT),
> +		 hnae3_get_field(fw_version,
> HNAE3_FW_VERSION_BYTE1_MASK,
> +				 HNAE3_FW_VERSION_BYTE1_SHIFT),
> +		 hnae3_get_field(fw_version,
> HNAE3_FW_VERSION_BYTE0_MASK,
> +				 HNAE3_FW_VERSION_BYTE0_SHIFT));
>  }
>  
>  static u32 hns3_get_link(struct net_device *netdev)
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c
> b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c
> index 22f6acd..c2320bf 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c
> @@ -419,7 +419,15 @@ int hclge_cmd_init(struct hclge_dev *hdev)
>  	}
>  	hdev->fw_version = version;
>  
> -	dev_info(&hdev->pdev->dev, "The firmware version is %08x\n",
> version);
> +	pr_info_once("The firmware version is %lu.%lu.%lu.%lu\n",
> +		     hnae3_get_field(version,
> HNAE3_FW_VERSION_BYTE3_MASK,
> +				     HNAE3_FW_VERSION_BYTE3_SHIFT),
> +		     hnae3_get_field(version,
> HNAE3_FW_VERSION_BYTE2_MASK,
> +				     HNAE3_FW_VERSION_BYTE2_SHIFT),
> +		     hnae3_get_field(version,
> HNAE3_FW_VERSION_BYTE1_MASK,
> +				     HNAE3_FW_VERSION_BYTE1_SHIFT),
> +		     hnae3_get_field(version,
> HNAE3_FW_VERSION_BYTE0_MASK,
> +				     HNAE3_FW_VERSION_BYTE0_SHIFT));
>  

Device name/string will not be printed now, what happens if i have
multiple devices ? at least print the device name as it was before

>  	return 0;
>  
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd.c
> b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd.c
> index 652b796..004125b 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd.c
> @@ -405,8 +405,15 @@ int hclgevf_cmd_init(struct hclgevf_dev *hdev)
>  	}
>  	hdev->fw_version = version;
>  
> -	dev_info(&hdev->pdev->dev, "The firmware version is %08x\n",
> version);
> -
> +	pr_info_once("The firmware version is %lu.%lu.%lu.%lu\n",
> +		     hnae3_get_field(version,
> HNAE3_FW_VERSION_BYTE3_MASK,
> +				     HNAE3_FW_VERSION_BYTE3_SHIFT),
> +		     hnae3_get_field(version,
> HNAE3_FW_VERSION_BYTE2_MASK,
> +				     HNAE3_FW_VERSION_BYTE2_SHIFT),
> +		     hnae3_get_field(version,
> HNAE3_FW_VERSION_BYTE1_MASK,
> +				     HNAE3_FW_VERSION_BYTE1_SHIFT),
> +		     hnae3_get_field(version,
> HNAE3_FW_VERSION_BYTE0_MASK,
> +				     HNAE3_FW_VERSION_BYTE0_SHIFT));
>  	return 0;
>  

Same.