linux-kernel - Re: [PATCH v2] RDMA/hns: Fix build error for hip06

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <62e79055-948e-155f-19eb-b216a540458a@huawei.com>
Date:   Wed, 24 Jul 2019 11:58:41 +0800
From:   Yuehaibing <yuehaibing@...wei.com>
To:     <oulijun@...wei.com>, <xavier.huwei@...wei.com>,
        <dledford@...hat.com>, <jgg@...pe.ca>, <leon@...nel.org>
CC:     <linux-kernel@...r.kernel.org>, <linux-rdma@...r.kernel.org>
Subject: Re: [PATCH v2] RDMA/hns: Fix build error for hip06


Pls ignore this, I will fix it.

On 2019/7/24 11:44, YueHaibing wrote:
> If INFINIBAND_HNS_HIP06 is selected and HNS_DSAF
> is m, but INFINIBAND_HNS is y, building fails:
> 
> drivers/infiniband/hw/hns/hns_roce_hw_v1.o: In function `hns_roce_v1_reset':
> hns_roce_hw_v1.c:(.text+0x39fa): undefined reference to `hns_dsaf_roce_reset'
> hns_roce_hw_v1.c:(.text+0x3a25): undefined reference to `hns_dsaf_roce_reset'
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Fixes: 08805fdbeb2d ("RDMA/hns: Split hw v1 driver from hns roce driver")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
> v2: use select instead of depends
> ---
>  drivers/infiniband/hw/hns/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/hns/Kconfig b/drivers/infiniband/hw/hns/Kconfig
> index b9dfac0..5f6d750 100644
> --- a/drivers/infiniband/hw/hns/Kconfig
> +++ b/drivers/infiniband/hw/hns/Kconfig
> @@ -12,7 +12,8 @@ config INFINIBAND_HNS
>  
>  config INFINIBAND_HNS_HIP06
>  	bool "Hisilicon Hip06 Family RoCE support"
> -	depends on INFINIBAND_HNS && HNS && HNS_DSAF && HNS_ENET
> +	depends on INFINIBAND_HNS && HNS && HNS_ENET
> +	select HNS_DSAF
>  	---help---
>  	  RoCE driver support for Hisilicon RoCE engine in Hisilicon Hip06 and
>  	  Hip07 SoC. These RoCE engines are platform devices.
>