linux-kernel - Re: linux-next: build warning after merge of the input-current tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <5463D761-FAFB-4BBE-8EE1-95EF1A52F927@canonical.com>
Date:   Wed, 24 Jul 2019 12:48:21 +0800
From:   Kai-Heng Feng <kai.heng.feng@...onical.com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Kees Cook <keescook@...omium.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Subject: Re: linux-next: build warning after merge of the input-current tree

Hi Stephen,

at 07:54, Stephen Rothwell <sfr@...b.auug.org.au> wrote:

> Hi all,
>
> After merging the input-current tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/input/mouse/elantech.c: In function 'elantech_use_host_notify':
> drivers/input/mouse/elantech.c:1843:6: warning: this statement may fall  
> through [-Wimplicit-fallthrough=]
>    if (dmi_get_bios_year() >= 2018)
>       ^
> drivers/input/mouse/elantech.c:1845:2: note: here
>   default:
>   ^~~~~~~
>
> Introduced by commit
>
>   883a2a80f79c ("Input: elantech - enable SMBus on new (2018+) systems")
>
> I get these warnings because I am building with -Wimplicit-fallthrough
> in attempt to catch new additions early.  The gcc warning can be turned
> off by adding a /* fall through */ comment at the point the fall through
> happens (assuming that the fall through is intentional).

Yes the fall through is intentional.

Kai-Heng

>
> -- 
> Cheers,
> Stephen Rothwell