linux-kernel - Re: [PATCH] kbuild: clean compressed initramfs image

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1563932322.lqg59sj895.astroid@bobo.none>
Date:   Wed, 24 Jul 2019 11:40:00 +1000
From:   Nicholas Piggin <npiggin@...il.com>
To:     Andrew Morton <akpm@...ux-foundation.org>,
        Greg Thelen <gthelen@...gle.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kbuild: clean compressed initramfs image

Greg Thelen's on July 22, 2019 4:32 pm:
> Since commit 9e3596b0c653 ("kbuild: initramfs cleanup, set target from
> Kconfig") "make clean" leaves behind compressed initramfs images.
> Example:
>   $ make defconfig
>   $ sed -i 's|CONFIG_INITRAMFS_SOURCE=""|CONFIG_INITRAMFS_SOURCE="/tmp/ir.cpio"|' .config
>   $ make olddefconfig
>   $ make -s
>   $ make -s clean
>   $ git clean -ndxf | grep initramfs
>   Would remove usr/initramfs_data.cpio.gz
> 
> clean rules do not have CONFIG_* context so they do not know which
> compression format was used.  Thus they don't know which files to
> delete.
> 
> Tell clean to delete all possible compression formats.
> 
> Once patched usr/initramfs_data.cpio.gz and friends are deleted by
> "make clean".
> 
> Fixes: 9e3596b0c653 ("kbuild: initramfs cleanup, set target from Kconfig")
> Signed-off-by: Greg Thelen <gthelen@...gle.com>

Thanks for that, looks good to me.

Thanks,
Nick