linux-kernel - Re: [PATCH 1/2] can: c_can: support 64 message objects for D

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <080346c5-eace-f0bc-ef3a-0354988b9fb4@pengutronix.de>
Date:   Wed, 24 Jul 2019 11:48:19 +0200
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Andrejs Cainikovs <Andrejs.Cainikovs@...module.com>,
        Wolfgang Grandegger <wg@...ndegger.com>,
        "linux-can@...r.kernel.org" <linux-can@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:     Patrick Zysset <Patrick.Zysset@...module.com>
Subject: Re: [PATCH 1/2] can: c_can: support 64 message objects for D_CAN

On 2/8/19 2:17 PM, Andrejs Cainikovs wrote:
> D_CAN supports up to 128 message objects, comparing to 32 on C_CAN.
> However, some CPUs with D_CAN controller have their own limits:
> TI AM335x Sitara CPU, for example, supports max of 64 message objects.
> 
> This patch extends max D_CAN message objects up to 64.

Please don't make this a kconfig option.

According to you description this is a HW feature, so please add the max
number of messe objects to "struct c_can_driver_data" and adjust the
drvdata accordingly.

> static const struct of_device_id c_can_of_table[] = {
> 	{ .compatible = "bosch,c_can", .data = &c_can_drvdata },
> 	{ .compatible = "bosch,d_can", .data = &d_can_drvdata },
> 	{ .compatible = "ti,dra7-d_can", .data = &dra7_dcan_drvdata },
> 	{ .compatible = "ti,am3352-d_can", .data = &am3352_dcan_drvdata },
> 	{ .compatible = "ti,am4372-d_can", .data = &am3352_dcan_drvdata },
> 	{ /* sentinel */ },
> };

You probably have to pass it via "struct c_can_priv" so that it's
available in the c_can.c

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)