linux-kernel - Re: [PATCH] tty/isicom: remove redundant assignment to variable word

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <90da3a1d-ff0f-937b-d212-bb5428486768@suse.com>
Date:   Wed, 24 Jul 2019 12:09:06 +0200
From:   Jiri Slaby <jslaby@...e.com>
To:     Colin King <colin.king@...onical.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty/isicom: remove redundant assignment to variable
 word_count

On 23. 07. 19, 17:03, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The variable word_count is being assigned a value that is never read before
> a return, the assignment is redundant and can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Looks good, it predates git. Maybe the while loop wanted to use
word_count originally.

Acked-by: Jiri Slaby <jslaby@...e.cz>

> ---
>  drivers/tty/isicom.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/tty/isicom.c b/drivers/tty/isicom.c
> index e04a43e89f6b..fc38f96475bf 100644
> --- a/drivers/tty/isicom.c
> +++ b/drivers/tty/isicom.c
> @@ -553,7 +553,6 @@ static irqreturn_t isicom_interrupt(int irq, void *dev_id)
>  
>  	tty = tty_port_tty_get(&port->port);
>  	if (tty == NULL) {
> -		word_count = byte_count >> 1;
>  		while (byte_count > 1) {
>  			inw(base);
>  			byte_count -= 2;
> 


-- 
js
suse labs