linux-kernel - Re: [PATCH] extcon: sm5502: Add IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2ff0d8e8-6916-666d-5757-657594b5238d@samsung.com>
Date:   Wed, 24 Jul 2019 19:34:24 +0900
From:   Chanwoo Choi <cw00.choi@...sung.com>
To:     Vasyl Gomonovych <gomonovych@...il.com>, myungjoo.ham@...sung.com
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] extcon: sm5502: Add IRQ_ONESHOT

On 19. 7. 20. 오전 1:28, Vasyl Gomonovych wrote:
> Do not fire irq again until thread done
> 
> Signed-off-by: Vasyl Gomonovych <gomonovych@...il.com>
> ---
> Can you please look on this from false positives point of view
> ---
>  drivers/extcon/extcon-sm5502.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/extcon/extcon-sm5502.c b/drivers/extcon/extcon-sm5502.c
> index 98e4f616b8f1..dc43847ad2b0 100644
> --- a/drivers/extcon/extcon-sm5502.c
> +++ b/drivers/extcon/extcon-sm5502.c
> @@ -597,7 +597,7 @@ static int sm5022_muic_i2c_probe(struct i2c_client *i2c,
>  
>  		ret = devm_request_threaded_irq(info->dev, virq, NULL,
>  						sm5502_muic_irq_handler,
> -						IRQF_NO_SUSPEND,
> +						IRQF_NO_SUSPEND | IRQF_ONESHOT,
>  						muic_irq->name, info);
>  		if (ret) {
>  			dev_err(info->dev,
> 

Applied it. Thanks.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics