linux-kernel - Re: [PATCH] mmc: sdhci-pci: Use dev_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1438432c-97b4-6a98-e62b-b492f627d060@intel.com>
Date:   Wed, 24 Jul 2019 16:05:47 +0300
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Chuhong Yuan <hslester96@...il.com>
Cc:     Ulf Hansson <ulf.hansson@...aro.org>, linux-mmc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: sdhci-pci: Use dev_get_drvdata

On 23/07/19 3:47 PM, Chuhong Yuan wrote:
> Instead of using to_pci_dev + pci_get_drvdata,
> use dev_get_drvdata to make code simpler.
> 
> Signed-off-by: Chuhong Yuan <hslester96@...il.com>

Acked-by: Adrian Hunter <adrian.hunter@...el.com>

> ---
>  drivers/mmc/host/sdhci-pci-core.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
> index 4041878eb0f3..d10aceed5bb7 100644
> --- a/drivers/mmc/host/sdhci-pci-core.c
> +++ b/drivers/mmc/host/sdhci-pci-core.c
> @@ -1759,8 +1759,7 @@ static const struct sdhci_ops sdhci_pci_ops = {
>  #ifdef CONFIG_PM_SLEEP
>  static int sdhci_pci_suspend(struct device *dev)
>  {
> -	struct pci_dev *pdev = to_pci_dev(dev);
> -	struct sdhci_pci_chip *chip = pci_get_drvdata(pdev);
> +	struct sdhci_pci_chip *chip = dev_get_drvdata(dev);
>  
>  	if (!chip)
>  		return 0;
> @@ -1773,8 +1772,7 @@ static int sdhci_pci_suspend(struct device *dev)
>  
>  static int sdhci_pci_resume(struct device *dev)
>  {
> -	struct pci_dev *pdev = to_pci_dev(dev);
> -	struct sdhci_pci_chip *chip = pci_get_drvdata(pdev);
> +	struct sdhci_pci_chip *chip = dev_get_drvdata(dev);
>  
>  	if (!chip)
>  		return 0;
> @@ -1789,8 +1787,7 @@ static int sdhci_pci_resume(struct device *dev)
>  #ifdef CONFIG_PM
>  static int sdhci_pci_runtime_suspend(struct device *dev)
>  {
> -	struct pci_dev *pdev = to_pci_dev(dev);
> -	struct sdhci_pci_chip *chip = pci_get_drvdata(pdev);
> +	struct sdhci_pci_chip *chip = dev_get_drvdata(dev);
>  
>  	if (!chip)
>  		return 0;
> @@ -1803,8 +1800,7 @@ static int sdhci_pci_runtime_suspend(struct device *dev)
>  
>  static int sdhci_pci_runtime_resume(struct device *dev)
>  {
> -	struct pci_dev *pdev = to_pci_dev(dev);
> -	struct sdhci_pci_chip *chip = pci_get_drvdata(pdev);
> +	struct sdhci_pci_chip *chip = dev_get_drvdata(dev);
>  
>  	if (!chip)
>  		return 0;
>