linux-kernel - Re: [PATCH -next] net/ixgbevf: fix a compilation error of skb_frag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190724135903.GU363@bombadil.infradead.org>
Date:   Wed, 24 Jul 2019 06:59:03 -0700
From:   Matthew Wilcox <willy@...radead.org>
To:     Qian Cai <cai@....pw>
Cc:     davem@...emloft.net, jeffrey.t.kirsher@...el.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] net/ixgbevf: fix a compilation error of skb_frag_t

On Wed, Jul 24, 2019 at 09:32:37AM -0400, Qian Cai wrote:
>  	for (f = 0; f < skb_shinfo(skb)->nr_frags; f++)
> -		count += TXD_USE_COUNT(skb_shinfo(skb)->frags[f].size);
> +		count += TXD_USE_COUNT(skb_shinfo(skb)->frags[f].bv_len);
>  #else

No, this is the wrong fix.  Use the fine accessor instead:

+		count += TXD_USE_COUNT(skb_frag_size(&skb_shinfo(skb)->frags[f]));

although now there's a line length problem.  Most drivers do:

		skb_frag_t frag = &skb_shinfo(skb)->frags[f];
		count += TXD_USE_COUNT(skb_frag_size(frag));