linux-kernel - Re: Backlight in motorola Droid 4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ca69f627-96e2-f982-3a29-18b0127ac6e5@ti.com>
Date:   Wed, 24 Jul 2019 10:22:12 -0500
From:   Dan Murphy <dmurphy@...com>
To:     Pavel Machek <pavel@....cz>
CC:     <linux-omap@...r.kernel.org>, <tony@...mide.com>, <sre@...nel.org>,
        <nekit1000@...il.com>, <mpartap@....net>, <merlijn@...zup.org>,
        <jacek.anaszewski@...il.com>, <linux-kernel@...r.kernel.org>,
        <linux-leds@...r.kernel.org>
Subject: Re: Backlight in motorola Droid 4

Pavel

On 7/24/19 7:45 AM, Pavel Machek wrote:
<snip>
>
> +
>   static int lm3532_parse_node(struct lm3532_data *priv)
>   {
>   	struct fwnode_handle *child = NULL;
> @@ -536,11 +579,13 @@ static int lm3532_parse_node(struct lm3532_data *priv)
>   		ret = fwnode_property_read_u32(child, "ti,led-mode",
>   					       &led->mode);
>   		if (ret) {
> +		  /* FIXME: should just default to non-als mod */

Looking at the rest of the code.

The DT doc indicated that this was a required child property so this is 
why it

errors out.

Dan

<snip>