linux-kernel - Re: [PATCH] USB: serial: option: Add Motorola modem UARTs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <75e9bccc-d76d-2bc6-f9f3-a0efc25e8238@gmail.com>
Date:   Wed, 24 Jul 2019 09:34:09 +0700
From:   Lars Melin <larsm17@...il.com>
To:     Tony Lindgren <tony@...mide.com>, Johan Hovold <johan@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-omap@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Bjørn Mork <bjorn@...k.no>,
        Dan Williams <dan.j.williams@...el.com>,
        Marcel Partap <mpartap@....net>,
        Merlijn Wajer <merlijn@...zup.org>,
        Michael Scott <hashcode0f@...il.com>,
        NeKit <nekit1000@...il.com>, Pavel Machek <pavel@....cz>,
        Sebastian Reichel <sre@...nel.org>
Subject: Re: [PATCH] USB: serial: option: Add Motorola modem UARTs

On 7/23/2019 21:49, Tony Lindgren wrote:

> +#define MOTOROLA_VENDOR_ID			0x22b8
> +#define MOTOROLA_PRODUCT_MDM6600		0x2a70
> +#define MOTOROLA_PRODUCT_MDM9600		0x2e0a
> +#define MOTOROLA_PRODUCT_MDM_RAM_DL		0x4281
> +#define MOTOROLA_PRODUCT_MDM_QC_DL		0x900e
> +

Johan, when he is back from vacation, will tell you to drop those 
defines and instead use the values directly in the list with a comment 
behind reflecting the device model.
Just telling you so you can save time by sending out your v2 early..


best rgds
/Lars