linux-kernel - Re: linux-next boot error: WARNING: workqueue cpumask: online intersect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190724174129.GE213255@gmail.com>
Date:   Wed, 24 Jul 2019 10:41:29 -0700
From:   Eric Biggers <ebiggers@...nel.org>
To:     Tejun Heo <tj@...nel.org>,
        Michael Bringmann <mwb@...ux.vnet.ibm.com>
Cc:     Dmitry Vyukov <dvyukov@...gle.com>,
        syzbot <syzbot+4d497898effeb1936245@...kaller.appspotmail.com>,
        Lai Jiangshan <jiangshanlai@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        syzkaller-bugs <syzkaller-bugs@...glegroups.com>
Subject: Re: linux-next boot error: WARNING: workqueue cpumask: online
 intersect > possible intersect

On Tue, Jul 23, 2019 at 09:31:27AM -0700, Eric Biggers wrote:
> On Tue, Jul 23, 2019 at 10:16:24AM +0200, 'Dmitry Vyukov' via syzkaller-bugs wrote:
> > On Tue, Jun 11, 2019 at 8:52 PM Tejun Heo <tj@...nel.org> wrote:
> > >
> > > Hello,
> > >
> > > On Fri, Jun 07, 2019 at 10:45:45AM +0200, Dmitry Vyukov wrote:
> > > > +workqueue maintainers and Michael who added this WARNING
> > > >
> > > > The WARNING was added in 2017, so I guess it's a change somewhere else
> > > > that triggered it.
> > > > The WARNING message does not seem to give enough info about the caller
> > > > (should it be changed to WARN_ONCE to print a stack?). How can be root
> > > > cause this and unbreak linux-next?
> > >
> > > So, during boot, workqueue builds masks of possible cpus of each node
> > > and stores them on wq_numa_possible_cpumask[] array.  The warning is
> > > saying that somehow online cpumask of a node became a superset of the
> > > possible mask, which should never happen.
> > >
> > > Dumping all masks in wq_numa_possible_cpumasks[] and cpumask_of_node()
> > > of each node should show what's going on.
> > 
> > This has reached upstream and all subsystem subtrees, now all Linux
> > trees are boot broken (except for few that still lack behind):
> > https://syzkaller.appspot.com/upstream
> > 
> > No new Linux code is tested by syzbot at this point.
> > 
> 
> AFAICS, what's actually happening is that the boot fails due to a different bug,
> "general protection fault in dma_direct_max_mapping_size" -- which is a real
> boot error, not just a warning; see
> https://lkml.kernel.org/lkml/20190723161425.GA23641@gmail.com/
> 
> syzbot then sees "WARNING: workqueue cpumask: online intersect > possible
> intersect" in the console output prior to that, and uses that as the bug title.
> 
> It's not obvious that syzbot would report "WARNING: workqueue cpumask: online
> intersect > possible intersect" without the real boot error too.
> 
> Nevertheless the issue is still there and something needs to be done about it.
> 

The real boot error "general protection fault in dma_direct_max_mapping_size" is
fixed in mainline now.  I believe that unblocks syzbot testing, since it doesn't
appear to have been blocked by "WARNING: workqueue cpumask: online intersect >
possible intersect" by itself.

Anyway: Tejun and Michael, any other ideas for why "WARNING: workqueue cpumask:
online intersect > possible intersect" is still happening?

- Eric