linux-kernel - Re: [PATCH v9 3/8] cpuset: Rebuild root domain deadline accounting information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANLsYkzd1Vt5L+tcmtnC+gm6MCe2yYWNi3WEif+4dN2DmcMijA@mail.gmail.com>
Date:   Thu, 25 Jul 2019 10:00:26 -0600
From:   Mathieu Poirier <mathieu.poirier@...aro.org>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     Juri Lelli <juri.lelli@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Steven Rostedt <rostedt@...dmis.org>, tj@...nel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "luca.abeni" <luca.abeni@...tannapisa.it>,
        Claudio Scordino <claudio@...dence.eu.com>,
        Tommaso Cucinotta <tommaso.cucinotta@...tannapisa.it>,
        Daniel Bristot de Oliveira <bristot@...hat.com>,
        Li Zefan <lizefan@...wei.com>, longman@...hat.com,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        cgroups@...r.kernel.org
Subject: Re: [PATCH v9 3/8] cpuset: Rebuild root domain deadline accounting information

On Thu, 25 Jul 2019 at 07:56, Ingo Molnar <mingo@...nel.org> wrote:
>
>
> * Ingo Molnar <mingo@...nel.org> wrote:
>
> >
> > * Juri Lelli <juri.lelli@...hat.com> wrote:
> >
> > > When the topology of root domains is modified by CPUset or CPUhotplug
> > > operations information about the current deadline bandwidth held in the
> > > root domain is lost.
> > >
> > > This patch addresses the issue by recalculating the lost deadline
> > > bandwidth information by circling through the deadline tasks held in
> > > CPUsets and adding their current load to the root domain they are
> > > associated with.
> > >
> > > Signed-off-by: Mathieu Poirier <mathieu.poirier@...aro.org>
> > > Signed-off-by: Juri Lelli <juri.lelli@...hat.com>
> >
> > Was this commit written by Mathieu? If yes then it's missing a From line.
> > If not then the Signed-off-by should probably be changed to Acked-by or
> > Reviewed-by?
>
> So for now I'm assuming that the original patch was written by Mathieu,
> with modifications by you. So I added his From line and extended the SOB
> chain with the additional information that you modified the patch:
>
>     Tested-by: Dietmar Eggemann <dietmar.eggemann@....com>
>     Signed-off-by: Mathieu Poirier <mathieu.poirier@...aro.org>
>     Signed-off-by: Juri Lelli <juri.lelli@...hat.com>
>     [ Various additional modifications. ]
>     Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
>     Signed-off-by: Ingo Molnar <mingo@...nel.org>
>
> Let me know if that's not accurate!

You are correct - thanks,
Mathieu

>
> Thanks,
>
>         Ingo