linux-kernel - Re: [PATCH] ARM: visit mach-* and plat-* directories when cleaning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190725164614.GJ1330@shell.armlinux.org.uk>
Date:   Thu, 25 Jul 2019 17:46:14 +0100
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     patches@....linux.org.uk, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: visit mach-* and plat-* directories when cleaning

On Fri, Jul 19, 2019 at 01:35:23AM +0900, Masahiro Yamada wrote:
> When you run "make clean" for arm, it never visits mach-* or plat-*
> directories because machine-y and plat-y are just empty.
> 
> When cleaning, all machine, plat directories are accumulated to
> machine-, plat-, respectively. So, let's pass them to core- to
> clean up those directories.

You don't say what actual, real-life issue this patch is solving.
Which files are left behind by a "make clean" ?

>From what I can see, this only matters if there are extra files that
are generated (and have set extra-* or clean-*).  Everything else is
cleaned up via the big find command in the top level makefile.

Or is this a "it would be nice if..." patch?

> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
> 
> KernelVersion: v5.3-rc1
> 
>  arch/arm/Makefile | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> index 792f7fa16a24..c3eb0d9a2fdd 100644
> --- a/arch/arm/Makefile
> +++ b/arch/arm/Makefile
> @@ -286,6 +286,10 @@ core-y				+= arch/arm/net/
>  core-y				+= arch/arm/crypto/
>  core-y				+= $(machdirs) $(platdirs)
>  
> +# For cleaning
> +core-				+= $(patsubst %,arch/arm/mach-%/, $(machine-))
> +core-				+= $(patsubst %,arch/arm/plat-%/, $(plat-))
> +
>  drivers-$(CONFIG_OPROFILE)      += arch/arm/oprofile/
>  
>  libs-y				:= arch/arm/lib/ $(libs-y)
> -- 
> 2.17.1
> 
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up