linux-kernel - Re: [PATCH] platform/x86/pcengines-apuv2: use KEY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <332c666b-1bb3-d4bb-ad1b-98b36992de71@metux.net>
Date:   Thu, 25 Jul 2019 20:50:27 +0200
From:   "Enrico Weigelt, metux IT consult" <lkml@...ux.net>
To:     Andy Shevchenko <andy.shevchenko@...il.com>,
        "Enrico Weigelt, metux IT consult" <info@...ux.net>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH] platform/x86/pcengines-apuv2: use KEY_RESTART for front
 button

On 25.07.19 19:17, Andy Shevchenko wrote:
> On Mon, Jul 22, 2019 at 2:36 PM Enrico Weigelt, metux IT consult
> <info@...ux.net> wrote:
>>
>> From: Enrico Weigelt <info@...ux.net>
>>
>> The keycode KEY_RESTART is more appropriate for the front button,
>> as most people use it for things like restart or factory reset.
>>
> 
> Should it go as Fixes?

I think so. Technically, the feature already worked, but the keycode
wasn't semantically fine.

--mtx

-- 
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@...ux.net -- +49-151-27565287