[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <37af3904-7fe7-d151-c82b-252f6bcd00ff@metux.net>
Date: Thu, 25 Jul 2019 21:06:20 +0200
From: "Enrico Weigelt, metux IT consult" <lkml@...ux.net>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: "Enrico Weigelt, metux IT consult" <info@...ux.net>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Darren Hart <dvhart@...radead.org>,
Andy Shevchenko <andy@...radead.org>,
Platform Driver <platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH] platform/x86/pcengines-apuv2: use KEY_RESTART for front
button
On 25.07.19 20:57, Andy Shevchenko wrote:
> On Thu, Jul 25, 2019 at 9:50 PM Enrico Weigelt, metux IT consult
> <lkml@...ux.net> wrote:
>>
>> On 25.07.19 19:17, Andy Shevchenko wrote:
>>> On Mon, Jul 22, 2019 at 2:36 PM Enrico Weigelt, metux IT consult
>>> <info@...ux.net> wrote:
>>>>
>>>> From: Enrico Weigelt <info@...ux.net>
>>>>
>>>> The keycode KEY_RESTART is more appropriate for the front button,
>>>> as most people use it for things like restart or factory reset.
>>>>
>>>
>>> Should it go as Fixes?
>>
>> I think so. Technically, the feature already worked, but the keycode
>> wasn't semantically fine.
>
> Can you provide a Fixes tag?
>
Okay, sent a v2.
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@...ux.net -- +49-151-27565287
Powered by blists - more mailing lists