linux-kernel - Re: [PATCH 1/1] riscv: Fix perf record without libelf support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.9999.1907251410240.32766@viisi.sifive.com>
Date:   Thu, 25 Jul 2019 14:11:46 -0700 (PDT)
From:   Paul Walmsley <paul.walmsley@...ive.com>
To:     Mao Han <han_mao@...ky.com>
cc:     linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
        linux-csky@...r.kernel.org, Palmer Dabbelt <palmer@...ive.com>,
        Albert Ou <aou@...s.berkeley.edu>
Subject: Re: [PATCH 1/1] riscv: Fix perf record without libelf support

On Thu, 11 Jul 2019, Mao Han wrote:

> This patch fix following perf record error by linking vdso.so with
> build id.
> 
> perf.data      perf.data.old
> [ perf record: Woken up 1 times to write data ]
> free(): double free detected in tcache 2
> Aborted
> 
> perf record use filename__read_build_id(util/symbol-minimal.c) to get
> build id when libelf is not supported. When vdso.so is linked without
> build id, the section size of PT_NOTE will be zero, buf size will
> realloc to zero and cause memory corruption.
> 
> Signed-off-by: Mao Han <han_mao@...ky.com>
> Cc: Paul Walmsley <paul.walmsley@...ive.com>
> Cc: Palmer Dabbelt <palmer@...ive.com>
> Cc: Albert Ou <aou@...s.berkeley.edu>

Thanks, queued for v5.3-rc.

Also: thanks for your patience on the perf callchain patches.


- Paul