linux-kernel - Re: x86 - clang / objtool status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+icZUVC+4-QP5Wj2DUxAZ9wP_Ox311k-EUKkAsSL+8S_j2j1A@mail.gmail.com>
Date:   Thu, 25 Jul 2019 08:17:16 +0200
From:   Sedat Dilek <sedat.dilek@...il.com>
To:     Thomas Gleixner <tglx@...utronix.de>,
        Josh Poimboeuf <jpoimboe@...hat.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Nathan Chancellor <natechancellor@...il.com>,
        clang-built-linux <clang-built-linux@...glegroups.com>,
        x86@...nel.org
Subject: Re: x86 - clang / objtool status

On Mon, Jul 22, 2019 at 5:40 PM Sedat Dilek <sedat.dilek@...il.com> wrote:
>
> On Fri, Jul 19, 2019 at 3:48 PM Sedat Dilek <sedat.dilek@...il.com> wrote:
> >
> > > First of all I find out that it is possible to download and apply the
> > > series (here: v2) from patchwork (see [1]).
> > > I highly appreciate to have this in Josh's Git [2].
> > >
> >
> > There it is.
> >
> > - sed@ -
> >
> > [1] https://git.kernel.org/pub/scm/linux/kernel/git/jpoimboe/linux.git/log/?h=objtool-many-fixes-v2
>
> next-20190722 has them.
>
> Parallely, I opened an CBL issue #617
> "drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool:
> .altinstr_replacement+0x86: redundant UACCESS disable"
>
> I hope Josh can look at this.
>
> - Sedat -
>
> [1] https://github.com/ClangBuiltLinux/linux/issues/617

The objtool warning is fixed by [1].

Now, I see only 3 objtool warnings (all "falls through to next function"):

drivers/gpu/drm/radeon/atom.o: warning: objtool: atom_op_move() falls
through to next function atom_op_and()
drivers/gpu/drm/radeon/evergreen_cs.o: warning: objtool:
evergreen_cs_parse() falls through to next function
evergreen_dma_cs_parse()
drivers/infiniband/hw/hfi1/platform.o: warning: objtool: tune_serdes()
falls through to next function apply_tx_lanes()

The other i915 call-trace I have seen was independent of $COMPILER and
the objtool warning (details see [2] and [3]).

I was able to boot into my system.

- Sedat -

[1] https://lore.kernel.org/patchwork/series/403494/mbox/
[2] https://lore.kernel.org/lkml/20190721142930.GA480@tigerII.localdomain/
[3] https://github.com/ClangBuiltLinux/linux/issues/617#issuecomment-514906560