linux-kernel - [PATCH] extcon: max77843: Add IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20190725065515.8220-1-gomonovych@gmail.com>
Date:   Thu, 25 Jul 2019 08:55:15 +0200
From:   Vasyl Gomonovych <gomonovych@...il.com>
To:     myungjoo.ham@...sung.com, cw00.choi@...sung.com
Cc:     Vasyl Gomonovych <gomonovych@...il.com>,
        linux-kernel@...r.kernel.org
Subject: [PATCH] extcon: max77843: Add IRQ_ONESHOT mask

Do not fire irq again until thread done
This issue was found by code inspection
Coccicheck irqf_oneshot.cocci

Signed-off-by: Vasyl Gomonovych <gomonovych@...il.com>
---
 drivers/extcon/extcon-max77843.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c
index a343a6ef3506..42b14c333b1c 100644
--- a/drivers/extcon/extcon-max77843.c
+++ b/drivers/extcon/extcon-max77843.c
@@ -905,7 +905,8 @@ static int max77843_muic_probe(struct platform_device *pdev)
 		muic_irq->virq = virq;
 
 		ret = devm_request_threaded_irq(&pdev->dev, virq, NULL,
-				max77843_muic_irq_handler, IRQF_NO_SUSPEND,
+				max77843_muic_irq_handler,
+				IRQF_NO_SUSPEND | IRQF_ONESHOT,
 				muic_irq->name, info);
 		if (ret) {
 			dev_err(&pdev->dev,
-- 
2.17.1