linux-kernel - Re: [PATCH] extcon: max14577: Add irq mask IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJKOXPe2eutXocY5Jo=Z4tksm4Bcpz7p_pj-vFDrNU3Ot=55Uw@mail.gmail.com>
Date:   Thu, 25 Jul 2019 09:24:17 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Vasyl Gomonovych <gomonovych@...il.com>
Cc:     Chanwoo Choi <cw00.choi@...sung.com>,
        Bartłomiej Żołnierkiewicz 
        <b.zolnierkie@...sung.com>, myungjoo.ham@...sung.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] extcon: max14577: Add irq mask IRQ_ONESHOT

On Thu, 25 Jul 2019 at 08:42, Vasyl Gomonovych <gomonovych@...il.com> wrote:
>
> Do not fire irq again until thread done
> This issue was found by code inspection
> Coccicheck irqf_oneshot.cocci

The same as in max77693 - this is virtual IRQ so no need for oneshot.
The hardware IRQ has oneshot set. Otherwise please provide slightly
more specific rationale for this commit.

Best regards,
Krzysztof

>
> Signed-off-by: Vasyl Gomonovych <gomonovych@...il.com>
> ---
>  drivers/extcon/extcon-max14577.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon-max14577.c b/drivers/extcon/extcon-max14577.c
> index 32f663436e6e..97c021512ffc 100644
> --- a/drivers/extcon/extcon-max14577.c
> +++ b/drivers/extcon/extcon-max14577.c
> @@ -698,7 +698,7 @@ static int max14577_muic_probe(struct platform_device *pdev)
>
>                 ret = devm_request_threaded_irq(&pdev->dev, virq, NULL,
>                                 max14577_muic_irq_handler,
> -                               IRQF_NO_SUSPEND,
> +                               IRQF_NO_SUSPEND | IRQF_ONESHOT,
>                                 muic_irq->name, info);
>                 if (ret) {
>                         dev_err(&pdev->dev,
> --
> 2.17.1
>