linux-kernel - Re: [PATCH v2 1/2] mtd: spi-nor: Move m25p80 code in spi-nor.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b60adcf5-e85b-875a-c041-6bff1cade296@microchip.com>
Date:   Thu, 25 Jul 2019 11:44:52 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <vigneshr@...com>, <miquel.raynal@...tlin.com>, <richard@....at>,
        <marek.vasut@...il.com>
CC:     <bbrezillon@...nel.org>, <yogeshnarayan.gaur@....com>,
        <linux-kernel@...r.kernel.org>, <linux-mtd@...ts.infradead.org>
Subject: Re: [PATCH v2 1/2] mtd: spi-nor: Move m25p80 code in spi-nor.c



On 07/25/2019 02:19 PM, Tudor.Ambarus@...rochip.com wrote:
> static int spi_nor_spimem_xfer_reg(struct spi_nor *nor, struct spi_mem_op *op)
> {
> 	if (!op || (op->data.nbytes && !nor->cmd_buf))

!nor->cmd_buf can't be NULL, we can get rid of this check too, and use
spi_mem_exec_op() directly when interacting with registers.

> 		return -EINVAL;
> 
> 	return spi_mem_exec_op(nor->spimem, op);
> }