linux-kernel - Re: [PATCH] mfd: rk808: mark pm functions __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 25 Jul 2019 13:02:47 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Tony Xie <tony.xie@...k-chips.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Stefan Mavrodiev <stefan@...mex.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: rk808: mark pm functions __maybe_unused

On Mon, 08 Jul 2019, Arnd Bergmann wrote:

> The newly added suspend/resume functions are only used if CONFIG_PM
> is enabled:
> 
> drivers/mfd/rk808.c:752:12: error: 'rk8xx_resume' defined but not used [-Werror=unused-function]
> drivers/mfd/rk808.c:732:12: error: 'rk8xx_suspend' defined but not used [-Werror=unused-function]
> 
> Mark them as __maybe_unused so the compiler can silently drop them
> when they are not needed.
> 
> Fixes: 586c1b4125b3 ("mfd: rk808: Add RK817 and RK809 support")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/mfd/rk808.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog