linux-kernel - Re: [PATCH -next] mfd: rk808: Mark rk8xx_resume and rk8xx_suspend as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190725121917.GH23883@dell>
Date:   Thu, 25 Jul 2019 13:19:17 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     tony.xie@...k-chips.com, stefan@...mex.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] mfd: rk808: Mark rk8xx_resume and rk8xx_suspend as
 __maybe_unused

On Thu, 11 Jul 2019, YueHaibing wrote:

> Fix build warning:
> 
> drivers/mfd/rk808.c:752:12: warning: 'rk8xx_resume' defined but not used [-Wunused-function]
> drivers/mfd/rk808.c:732:12: warning: 'rk8xx_suspend' defined but not used [-Wunused-function]
> 
> The function is declared unconditionally but only called
> while CONFIG_PM_SLEEP is set.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/mfd/rk808.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Arnd already fixed this.

> diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c
> index 601cefb..9a9e631 100644
> --- a/drivers/mfd/rk808.c
> +++ b/drivers/mfd/rk808.c
> @@ -729,7 +729,7 @@ static int rk808_remove(struct i2c_client *client)
>  	return 0;
>  }
>  
> -static int rk8xx_suspend(struct device *dev)
> +static int __maybe_unused rk8xx_suspend(struct device *dev)
>  {
>  	struct rk808 *rk808 = i2c_get_clientdata(rk808_i2c_client);
>  	int ret = 0;
> @@ -749,7 +749,7 @@ static int rk8xx_suspend(struct device *dev)
>  	return ret;
>  }
>  
> -static int rk8xx_resume(struct device *dev)
> +static int __maybe_unused rk8xx_resume(struct device *dev)
>  {
>  	struct rk808 *rk808 = i2c_get_clientdata(rk808_i2c_client);
>  	int ret = 0;

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog