linux-kernel - Re: [PATCH] net: dsa: Check existence of .port_mdb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190725134209.GE21952@lunn.ch>
Date:   Thu, 25 Jul 2019 15:42:09 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Chen-Yu Tsai <wens@...nel.org>
Cc:     Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Chen-Yu Tsai <wens@...e.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: dsa: Check existence of .port_mdb_add callback
 before calling it

On Wed, Jul 24, 2019 at 11:47:02AM +0800, Chen-Yu Tsai wrote:
> From: Chen-Yu Tsai <wens@...e.org>
> 
> With the recent addition of commit 75dad2520fc3 ("net: dsa: b53: Disable
> all ports on setup"), users of b53 (BCM53125 on Lamobo R1 in my case)
> are forced to use the dsa subsystem to enable the switch, instead of
> having it in the default transparent "forward-to-all" mode.

Hi Chen-Yu

I would do the check earlier, at the beginning of
dsa_switch_mdb_add(). It is then similar to dsa_switch_mdb_del().

	      Andrew