linux-kernel - Re: [PATCH v2] f2fs: use EINVAL for superblock with invalid magic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 25 Jul 2019 11:15:01 +0800
From:   Chao Yu <yuchao0@...wei.com>
To:     Icenowy Zheng <icenowy@...c.io>, Jaegeuk Kim <jaegeuk@...nel.org>
CC:     <linux-f2fs-devel@...ts.sourceforge.net>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] f2fs: use EINVAL for superblock with invalid magic

On 2019/7/25 11:08, Icenowy Zheng wrote:
> The kernel mount_block_root() function expects -EACESS or -EINVAL for a
> unmountable filesystem when trying to mount the root with different
> filesystem types.
> 
> However, in 5.3-rc1 the behavior when F2FS code cannot find valid block
> changed to return -EFSCORRUPTED(-EUCLEAN), and this error code makes
> mount_block_root() fail when trying to probe F2FS.
> 
> When the magic number of the superblock mismatches, it has a high
> probability that it's just not a F2FS. In this case return -EINVAL seems
> to be a better result, and this return value can make mount_block_root()
> probing work again.
> 
> Return -EINVAL when the superblock has magic mismatch, -EFSCORRUPTED in
> other cases (the magic matches but the superblock cannot be recognized).
> 
> Fixes: 10f966bbf521 ("f2fs: use generic EFSBADCRC/EFSCORRUPTED")
> Signed-off-by: Icenowy Zheng <icenowy@...c.io>

Reviewed-by: Chao Yu <yuchao0@...wei.com>

Thanks,