linux-kernel - Re: [PATCH] staging: rtl8723bs: Disable procfs debugging by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <83A2CB3F-B0C4-43C6-A3A6-B6E8B440BECC@canonical.com>
Date:   Thu, 25 Jul 2019 22:48:42 +0800
From:   Kai-Heng Feng <kai.heng.feng@...onical.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: Disable procfs debugging by default

at 15:55, Greg KH <gregkh@...uxfoundation.org> wrote:

> On Thu, Jul 18, 2019 at 05:25:22PM +0800, Kai-Heng Feng wrote:
>> The procfs provides many useful information for debugging, but it may be
>> too much for normal usage, routines like proc_get_sec_info() reports
>> various security related information.
>>
>> So disable it by defaultl.
>>
>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>
>> ---
>>  drivers/staging/rtl8723bs/include/autoconf.h | 4 ----
>>  1 file changed, 4 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8723bs/include/autoconf.h  
>> b/drivers/staging/rtl8723bs/include/autoconf.h
>> index 196aca3aed7b..8f4c1e734473 100644
>> --- a/drivers/staging/rtl8723bs/include/autoconf.h
>> +++ b/drivers/staging/rtl8723bs/include/autoconf.h
>> @@ -57,9 +57,5 @@
>>  #define DBG	0	/*  for ODM & BTCOEX debug */
>>  #endif /*  !DEBUG */
>>
>> -#ifdef CONFIG_PROC_FS
>> -#define PROC_DEBUG
>> -#endif
>
> What?  Why?  If you are going to do this, then rip out all of the code
> as well.

Or make it a Kconfig option? Which one do you think is better?

>
> And are you _sure_ you want to do this?

Yes. The procfs of rtl8723bs is useful to Realtek to decode but not to  
others.

Kai-Heng

>
> thanks,
>
> greg k-h