linux-kernel - Re: [BUG] fs: f2fs: Possible null-pointer dereferences in update_general

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <889d8107-a122-cc15-ed08-959b34dcf248@gmail.com>
Date:   Fri, 26 Jul 2019 11:39:04 +0800
From:   Jia-Ju Bai <baijiaju1990@...il.com>
To:     Chao Yu <yuchao0@...wei.com>, jaegeuk@...nel.org
Cc:     linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [BUG] fs: f2fs: Possible null-pointer dereferences in
 update_general_status()



On 2019/7/26 11:19, Chao Yu wrote:
> Hi Jiaju,
>
> Thanks for the report, I checked the code, and found it doesn't need to check
> SM_I(sbi) pointer, this is because in fill_super() and put_super(), we will call
> f2fs_destroy_stats() in prior to f2fs_destroy_segment_manager(), so if current
> sbi can still be visited in global stat list, SM_I(sbi) should be released yet.
> So anyway, let's remove unneeded check in line 70/78. :)

Okay, I will send a patch to remove unneeded checks.


Best wishes,
Jia-Ju Bai