linux-kernel - Re: [PATCH] fs: f2fs: Remove unnecessary checks of SM_I(sbi) in update_general

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <039c2c03-51eb-0666-bfac-696fb678a733@huawei.com>
Date:   Fri, 26 Jul 2019 11:55:26 +0800
From:   Chao Yu <yuchao0@...wei.com>
To:     Jia-Ju Bai <baijiaju1990@...il.com>, <jaegeuk@...nel.org>
CC:     <linux-f2fs-devel@...ts.sourceforge.net>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fs: f2fs: Remove unnecessary checks of SM_I(sbi) in
 update_general_status()

On 2019/7/26 11:45, Jia-Ju Bai wrote:
> In fill_super() and put_super(), f2fs_destroy_stats() is called 
> in prior to f2fs_destroy_segment_manager(), so if current
> sbi can still be visited in global stat list, SM_I(sbi) should be
> released yet.
> For this reason, SM_I(sbi) does not need to be checked in
> update_general_status().
> Thank Chao Yu for advice.
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1990@...il.com>

Reviewed-by: Chao Yu <yuchao0@...wei.com>

Thanks,