[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <29a2d999-23bd-8e95-a1b8-f00e25a11df5@linux.intel.com>
Date: Sat, 27 Jul 2019 01:04:51 +0800
From: "Wang, Haiyue" <haiyue.wang@...ux.intel.com>
To: Andrew Jeffery <andrew@...id.au>, linux-aspeed@...ts.ozlabs.org
Cc: robh+dt@...nel.org, mark.rutland@....com, joel@....id.au,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, Corey Minyard <minyard@....org>,
Arnd Bergmann <arnd@...db.de>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
openipmi-developer@...ts.sourceforge.net
Subject: Re: [RFC PATCH 14/17] ipmi: kcs: Finish configuring ASPEED KCS device
before enable
在 2019-07-26 13:39, Andrew Jeffery 写道:
> The currently interrupts are configured after the channel was enabled.
>
> Cc: Haiyue Wang<haiyue.wang@...ux.intel.com>
> Cc: Corey Minyard<minyard@....org>
> Cc: Arnd Bergmann<arnd@...db.de>
> Cc: Greg Kroah-Hartman<gregkh@...uxfoundation.org>
> Cc:openipmi-developer@...ts.sourceforge.net
> Signed-off-by: Andrew Jeffery<andrew@...id.au>
> ---
> drivers/char/ipmi/kcs_bmc_aspeed.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/char/ipmi/kcs_bmc_aspeed.c b/drivers/char/ipmi/kcs_bmc_aspeed.c
> index 3c955946e647..e3dd09022589 100644
> --- a/drivers/char/ipmi/kcs_bmc_aspeed.c
> +++ b/drivers/char/ipmi/kcs_bmc_aspeed.c
> @@ -268,13 +268,14 @@ static int aspeed_kcs_probe(struct platform_device *pdev)
> kcs_bmc->io_inputb = aspeed_kcs_inb;
> kcs_bmc->io_outputb = aspeed_kcs_outb;
>
> + rc = aspeed_kcs_config_irq(kcs_bmc, pdev);
> + if (rc)
> + return rc;
> +
> dev_set_drvdata(dev, kcs_bmc);
Thanks for catching this, for not miss the data.
Powered by blists - more mailing lists