[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4b1f657c-e75f-d817-aa86-4224ce459a01@linux.intel.com>
Date: Fri, 26 Jul 2019 12:22:14 -0500
From: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To: Guennadi Liakhovetski <guennadi.liakhovetski@...ux.intel.com>
Cc: alsa-devel@...a-project.org, tiwai@...e.de,
gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
vkoul@...nel.org, broonie@...nel.org,
srinivas.kandagatla@...aro.org, jank@...ence.com,
slawomir.blauciak@...el.com, Sanyog Kale <sanyog.r.kale@...el.com>
Subject: Re: [alsa-devel] [RFC PATCH 35/40] soundwire: intel: export helper to
exit reset
>> @@ -161,6 +161,7 @@ irqreturn_t sdw_cdns_thread(int irq, void *dev_id);
>> int sdw_cdns_init(struct sdw_cdns *cdns);
>> int sdw_cdns_pdi_init(struct sdw_cdns *cdns,
>> struct sdw_cdns_stream_config config);
>> +int sdw_cdns_exit_reset(struct sdw_cdns *cdns);
>> int sdw_cdns_enable_interrupt(struct sdw_cdns *cdns);
>>
>> void sdw_cdns_debugfs_init(struct sdw_cdns *cdns, struct dentry *root);
>> diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
>> index a976480d6f36..9ebe38e4d979 100644
>> --- a/drivers/soundwire/intel.c
>> +++ b/drivers/soundwire/intel.c
>> @@ -1112,6 +1112,8 @@ static int intel_probe(struct platform_device *pdev)
>>
>> ret = sdw_cdns_enable_interrupt(&sdw->cdns);
>>
>> + ret = sdw_cdns_exit_reset(&sdw->cdns);
>
> This isn't something, that this patch changes, but if the return value above is
> ignored, maybe no need to assign it at all?
The return of these two functions was used with in some logs at some
point but they obviously vanished.
I'll re-check if we care about the status, could be that it never fails
Thanks!
>> +
>> /* Register DAIs */
>> ret = intel_register_dai(sdw);
>> if (ret) {
>> @@ -1199,6 +1201,8 @@ static int intel_resume(struct device *dev)
>>
>> sdw_cdns_enable_interrupt(&sdw->cdns);
>>
>> + ret = sdw_cdns_exit_reset(&sdw->cdns);
>> +
>> return ret;
Powered by blists - more mailing lists