linux-kernel - Re: [RFC PATCH 15/17] ipmi: kcs: aspeed: Implement v2 bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89ea7e21-944e-3d89-05b7-2dedb7916fa9@linux.intel.com>
Date:   Sat, 27 Jul 2019 01:30:24 +0800
From:   "Wang, Haiyue" <haiyue.wang@...ux.intel.com>
To:     Andrew Jeffery <andrew@...id.au>, linux-aspeed@...ts.ozlabs.org
Cc:     robh+dt@...nel.org, mark.rutland@....com, joel@....id.au,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Corey Minyard <minyard@....org>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        openipmi-developer@...ts.sourceforge.net
Subject: Re: [RFC PATCH 15/17] ipmi: kcs: aspeed: Implement v2 bindings


在 2019-07-26 13:39, Andrew Jeffery 写道:
> The v2 bindings allow us to extract the resources from the devicetree.
> The table in the driver is retained to derive the channel index, which
> removes the need for kcs_chan property from the v1 bindings. The v2
> bindings allow us to reduce the number of warnings generated by the
> existing devicetree nodes.
>
> Cc: Haiyue Wang<haiyue.wang@...ux.intel.com>
> Cc: Corey Minyard<minyard@....org>
> Cc: Arnd Bergmann<arnd@...db.de>
> Cc: Greg Kroah-Hartman<gregkh@...uxfoundation.org>
> Cc:openipmi-developer@...ts.sourceforge.net
> Signed-off-by: Andrew Jeffery<andrew@...id.au>
> ---
>   drivers/char/ipmi/kcs_bmc_aspeed.c | 156 +++++++++++++++++++++++------
>   1 file changed, 127 insertions(+), 29 deletions(-)

Looks good, thanks for the hard work, the code is more clean! :)

Reviewed-by: Haiyue Wang <haiyue.wang@...ux.intel.com>