linux-kernel - Re: [PATCH 1/6] staging: rtl8188eu: add spaces around '+' in usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 26 Jul 2019 11:21:36 -0700
From:   Joe Perches <joe@...ches.com>
To:     Michael Straube <straube.linux@...il.com>,
        gregkh@...uxfoundation.org
Cc:     Larry.Finger@...inger.net, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] staging: rtl8188eu: add spaces around '+' in
 usb_halinit.c

On Fri, 2019-07-26 at 20:04 +0200, Michael Straube wrote:
> Add spaces around '+' to improve readability and follow kernel
> coding style. Reported by checkpatch.

My preference would be to do all the horizontal whitespace
changes for the entire driver in one go without worrying
about long lines.

$ git ls-files -- 'drivers/staging/rtl8188eu/*.[ch]' | \
  xargs ./scripts/checkpatch.pl -f --types=SPACING --fix-inplace
$ git diff -w drivers/staging/rtl8188eu/
$ git diff --shortstat drivers/staging/rtl8188eu
 35 files changed, 603 insertions(+), 603 deletions(-)

Mention that git diff -w shows no difference and
verify that object files are unchanged and mention
both in the changelog.

Subject could be something like:

staging: rtl8188eu: Use typical kernel horizontal whitespace