[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20190726184306.GA14981@ravnborg.org>
Date: Fri, 26 Jul 2019 20:43:06 +0200
From: Sam Ravnborg <sam@...nborg.org>
To: Guido Günther <agx@...xcpu.org>
Cc: Purism Kernel Team <kernel@...i.sm>,
Thierry Reding <thierry.reding@...il.com>,
David Airlie <airlied@...ux.ie>,
Daniel Vetter <daniel@...ll.ch>,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/4] drm/panel: jh057n00900: Move dsi init sequence to
prepare
Hi Guido.
On Fri, Jul 26, 2019 at 03:14:35PM +0200, Guido Günther wrote:
>
> If the panel is wrapped in a panel_bridge it gets prepar()ed before the
> upstream DSI bridge which can cause hangs (e.g. with imx-nwl since clocks
> are not enabled yet). To avoid this move the panel's first DSI access to
> enable() so the upstream bridge can prepare the DSI host controller in
> it's pre_enable().
>
> The second patch makes the disable() call symmetric to the above and the third
> one just eases debugging.
>
> Changes from v1:
> * As per review comments by Sam Ravnborg
> * Ignore failures to disable the backlight in jh057n_disable()
> * Add 'drm/panel: jh057n00900: Use drm_panel_{unprepare,disable} consistently'
> * Collected Reviewed-By: Thanks Sam!
>
> To: "Guido Günther" <agx@...xcpu.org>,Purism Kernel Team <kernel@...i.sm>,Thierry Reding <thierry.reding@...il.com>,Sam Ravnborg <sam@...nborg.org>,David Airlie <airlied@...ux.ie>,Daniel Vetter <daniel@...ll.ch>,dri-devel@...ts.freedesktop.org,linux-kernel@...r.kernel.org
>
>
> Guido Günther (4):
> drm/panel: jh057n00900: Move panel DSI init to enable()
> drm/panel: jh057n00900: Move mipi_dsi_dcs_set_display_off to disable()
> drm/panel: jh057n00900: Print error code on all DRM_DEV_ERROR()s
> drm/panel: jh057n00900: Use drm_panel_{unprepare,disable} consistently
Looks good. Series applied to drm-misc-next and pushed out.
Sam
Powered by blists - more mailing lists