[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <201907270451.FVsMeeYH%lkp@intel.com>
Date: Sat, 27 Jul 2019 04:45:07 +0800
From: kbuild test robot <lkp@...el.com>
To: Richard Tresidder <rtresidd@...ctromag.com.au>
Cc: kbuild-all@...org, sre@...nel.org, enric.balletbo@...labora.com,
ncrews@...omium.org, andrew.smirnov@...il.com, groeck@...omium.org,
david@...hnology.com, rtresidd@...ctromag.com.au,
tglx@...utronix.de, linux-pm@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] power/supply/powersupply_sysfs: Add of_node name to
uevent message if available
Hi Richard,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.3-rc1 next-20190726]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Richard-Tresidder/power-supply-powersupply_sysfs-Add-of_node-name-to-uevent-message-if-available/20190727-033750
config: arm-omap2plus_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
drivers/power/supply/power_supply_sysfs.c: In function 'power_supply_uevent':
>> drivers/power/supply/power_supply_sysfs.c:400:22: error: dereferencing pointer to incomplete type 'struct device_node'
psy->of_node->name);
^~
vim +400 drivers/power/supply/power_supply_sysfs.c
381
382 int power_supply_uevent(struct device *dev, struct kobj_uevent_env *env)
383 {
384 struct power_supply *psy = dev_get_drvdata(dev);
385 int ret = 0, j;
386 char *prop_buf;
387 char *attrname;
388
389 if (!psy || !psy->desc) {
390 dev_dbg(dev, "No power supply yet\n");
391 return ret;
392 }
393
394 ret = add_uevent_var(env, "POWER_SUPPLY_NAME=%s", psy->desc->name);
395 if (ret)
396 return ret;
397
398 if (psy->of_node) {
399 ret = add_uevent_var(env, "POWER_SUPPLY_OF_NODE_NAME=%s",
> 400 psy->of_node->name);
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Download attachment ".config.gz" of type "application/gzip" (36719 bytes)
Powered by blists - more mailing lists