linux-kernel - Re: [PATCH] fs: reiserfs: Fix possible null-pointer dereferences in remove_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190726155416.86f1b96302273b91129e6dc3@linux-foundation.org>
Date:   Fri, 26 Jul 2019 15:54:16 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Jia-Ju Bai <baijiaju1990@...il.com>
Cc:     jack@...e.cz, arnd@...db.de, linux.bhar@...il.com,
        hariprasad.kelam@...il.com, reiserfs-devel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs: reiserfs: Fix possible null-pointer dereferences in
 remove_from_transaction()

On Fri, 26 Jul 2019 16:38:38 +0800 Jia-Ju Bai <baijiaju1990@...il.com> wrote:

> In remove_from_transaction(), there is an if statement on line 3447 to
> check whether bh is NULL:
>     if (bh)

We already know that bh != NULL here.

	cn = get_journal_hash_dev(sb, journal->j_hash_table, blocknr);
	if (!cn || !cn->bh) {
		return ret;
	}
	bh = cn->bh;


Please prepare a patch to remove the unneeded test?