linux-kernel - Re: [PATCH v2] checkpatch.pl: warn on invalid commit id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 Jul 2019 03:17:32 +0200
From:   Matteo Croce <mcroce@...hat.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
CC:     Joe Perches <joe@...ches.com>, LKML <linux-kernel@...r.kernel.org>,
        Andy Whitcroft <apw@...onical.com>
Subject: Re: [PATCH v2] checkpatch.pl: warn on invalid commit id

On July 26, 2019 2:22:05 AM GMT+02:00, Andrew Morton <akpm@...ux-foundation.org> wrote:
> On Thu, 25 Jul 2019 11:26:04 +0200 Matteo Croce <mcroce@...hat.com>
> wrote:
> 
> > On Thu, Jul 25, 2019 at 5:07 AM Andrew Morton
> <akpm@...ux-foundation.org> wrote:
> > > What does it do if we're not operating in a git directory? For
> example,
> > > I work in /usr/src/25 and my git repo is in ../git26.
> > >
> > 
> > If .git is not found, the check is disabled
> 
> We could permit user to set an environment variable to tell checkpatch
> where the kernel git tree resides.
> 

Maybe GIT_DIR already does it.

> > > Also, what happens relatively often is that someone quotes a
> linux-next
> > > or long-term-stable hash.  If the user has those trees in the git
> repo,
> > > I assume they won't be informed of the inappropriate hash?
> > >
> > 
> > In this case it won't warn, but this should not be a problem, as the
> > hash doesn't change following a merge.
> > The problem is just if the other tree gets rebased, or if the other
> > tree gets never merged, e.g. stable/linux-*
> 
> linux-next patches get rebased quite often.

I see :)

-- 
Matteo Croce
per aspera ad upstream