linux-kernel - Re: [PATCH] irqchip/gic-v3-its: Free unused vpt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 Jul 2019 10:18:44 +0100
From:   Marc Zyngier <marc.zyngier@....com>
To:     Shaokun Zhang <zhangshaokun@...ilicon.com>
Cc:     <linux-kernel@...r.kernel.org>,
        Nianyao Tang <tangnianyao@...wei.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>
Subject: Re: [PATCH] irqchip/gic-v3-its: Free unused vpt_page when alloc vpe
 table fail

On Fri, 26 Jul 2019 09:51:45 +0800
Shaokun Zhang <zhangshaokun@...ilicon.com> wrote:

> From: Nianyao Tang <tangnianyao@...wei.com>
> 
> In its_vpe_init, when its_alloc_vpe_table fails, we should free
> vpt_page allocated just before, instead of vpe->vpt_page.
> Let's fix it.
> 
> Cc: Thomas Gleixner <tglx@...utronix.de> 
> Cc: Jason Cooper <jason@...edaemon.net>
> Cc: Marc Zyngier <marc.zyngier@....com>
> Signed-off-by: Nianyao Tang <tangnianyao@...wei.com>
> ---
>  drivers/irqchip/irq-gic-v3-its.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
> index 730fbe0..1b5c367 100644
> --- a/drivers/irqchip/irq-gic-v3-its.c
> +++ b/drivers/irqchip/irq-gic-v3-its.c
> @@ -3010,7 +3010,7 @@ static int its_vpe_init(struct its_vpe *vpe)
>  
>  	if (!its_alloc_vpe_table(vpe_id)) {
>  		its_vpe_id_free(vpe_id);
> -		its_free_pending_table(vpe->vpt_page);
> +		its_free_pending_table(vpt_page);
>  		return -ENOMEM;
>  	}
>  

Oops, well caught. Please repost this patch with your own SoB added
though, as you're posting the patch on behalf of someone else.

Thanks,

	M.
-- 
Without deviation from the norm, progress is not possible.