linux-kernel - Re: [OFFLIST] [PATCH v1 0/2] pidfd: waiting on processes through pidfds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190726100252.GB16112@redhat.com>
Date:   Fri, 26 Jul 2019 12:02:53 +0200
From:   Oleg Nesterov <oleg@...hat.com>
To:     Christian Brauner <christian@...uner.io>
Cc:     linux-kernel@...r.kernel.org, arnd@...db.de, ebiederm@...ssion.com,
        keescook@...omium.org, joel@...lfernandes.org, tglx@...utronix.de,
        tj@...nel.org, dhowells@...hat.com, jannh@...gle.com,
        luto@...nel.org, akpm@...ux-foundation.org, cyphar@...har.com,
        torvalds@...ux-foundation.org, viro@...iv.linux.org.uk,
        kernel-team@...roid.com
Subject: Re: [OFFLIST] [PATCH v1 0/2] pidfd: waiting on processes through
 pidfds

Hi Christian,

just fyi, can't read this patch till Monday


On 07/26, Christian Brauner wrote:
> Hey everyone,
> 
> /* v1 */
> This adds the ability to wait on processes using pidfds. This is one of
> the few missing pieces to make it possible to manage processes using
> only pidfds.
> 
> Please note the following major changes (More details can be found in
> the individual commit changelogs.):
> - Add the new type P_PIDFD to waitid() instead of a new dedicated
>   pidfd_wait() syscall.
>   This is the same approach we discussed a few months ago and still
>   prefer over adding a dedicated syscall.
> - Adapt the tests to the new type P_PIDFD for waitid().
> - Remove struct waitid_info patch.
>   This will be sent out as a separate patch.
> - Remove CLONE_WAIT_PID patch.
>   This will be sent out as a separate patch.
> 
> The core patch for waitid is pleasantly small. The largest change is
> caused by adding proper tests for waitid(P_PIDFD).
> 
> /* v0 */
> Link: https://lore.kernel.org/lkml/20190724144651.28272-1-christian@brauner.io
> 
> Thanks!
> Christian
> 
> Christian Brauner (2):
>   pidfd: add P_PIDFD to waitid()
>   pidfd: add pidfd_wait tests
> 
>  include/linux/pid.h                        |   4 +
>  include/uapi/linux/wait.h                  |   1 +
>  kernel/exit.c                              |  25 ++-
>  kernel/fork.c                              |   8 +
>  kernel/signal.c                            |   7 +-
>  tools/testing/selftests/pidfd/pidfd.h      |  25 +++
>  tools/testing/selftests/pidfd/pidfd_test.c |  14 --
>  tools/testing/selftests/pidfd/pidfd_wait.c | 245 +++++++++++++++++++++
>  8 files changed, 311 insertions(+), 18 deletions(-)
>  create mode 100644 tools/testing/selftests/pidfd/pidfd_wait.c
> 
> -- 
> 2.22.0
>