linux-kernel - Re: [PATCH] pata_ali: check the pci_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5999d94d-1e6b-541e-8cba-55270742613c@samsung.com>
Date:   Fri, 26 Jul 2019 12:32:51 +0200
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     Navid Emamdoost <navid.emamdoost@...il.com>
Cc:     emamd001@....edu, kjlu@....edu, smccaman@....edu,
        secalert@...hat.com, Jens Axboe <axboe@...nel.dk>,
        linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pata_ali: check the pci_get_device failure


Hi,

On 7/25/19 3:25 AM, Navid Emamdoost wrote:
> pci_get_device may fail and return NULL. This eventually will be
> dereferenced in __pci_register_driver. So null check is necessary.

I'm sorry to say this but the patch is incorrect and should not be
applied.

ALI M1533 ISA bridge presence is optional (the driver can work also
with other ISA bridges) and ali_isa_bridge is always correctly checked
for NULL before being dereferenced in the driver.

> Signed-off-by: Navid Emamdoost <navid.emamdoost@...il.com>
> ---
>  drivers/ata/pata_ali.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/ata/pata_ali.c b/drivers/ata/pata_ali.c
> index 0b122f903b8a..47d9bec1f2e2 100644
> --- a/drivers/ata/pata_ali.c
> +++ b/drivers/ata/pata_ali.c
> @@ -627,6 +627,8 @@ static int __init ali_init(void)
>  {
>  	int ret;
>  	ali_isa_bridge = pci_get_device(PCI_VENDOR_ID_AL, PCI_DEVICE_ID_AL_M1533, NULL);
> +	if (!ali_isa_bridge)
> +		return -EINVAL;
>  
>  	ret = pci_register_driver(&ali_pci_driver);
>  	if (ret < 0)

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics