[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20190726121207.GU9224@smile.fi.intel.com>
Date: Fri, 26 Jul 2019 15:12:07 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Chanwoo Choi <cw00.choi@...sung.com>,
MyungJoo Ham <myungjoo.ham@...sung.com>,
linux-kernel@...r.kernel.org, Hans de Goede <hdegoede@...hat.com>,
Chen-Yu Tsai <wens@...e.org>
Cc: Ramakrishna Pallala <ramakrishna.pallala@...el.com>
Subject: Re: [PATCH v1 1/2] extcon: axp288: Add missed error check
On Fri, Jul 26, 2019 at 10:15:30AM +0900, Chanwoo Choi wrote:
> On 19. 7. 26. 오전 5:34, Andy Shevchenko wrote:
> > It seems from the very beginning the error check has been missed
> > in axp288_extcon_log_rsi(). Add it here.
> > ret = regmap_read(info->regmap, AXP288_PS_BOOT_REASON_REG, &val);
> > + if (ret < 0)
> > + return;
>
> It need to print error log because axp288_extcon_log_rsi() has the void'
> return type if there is no any error log, it is not possible to check
> the error status.
Makes sense.
Will add in v2.
P.S. You answered privately, I had returned Cc list back.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists