[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20190726121820.69679-1-andriy.shevchenko@linux.intel.com>
Date: Fri, 26 Jul 2019 15:18:19 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: MyungJoo Ham <myungjoo.ham@...sung.com>,
Chanwoo Choi <cw00.choi@...sung.com>,
linux-kernel@...r.kernel.org, Hans de Goede <hdegoede@...hat.com>,
Chen-Yu Tsai <wens@...e.org>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Ramakrishna Pallala <ramakrishna.pallala@...el.com>
Subject: [PATCH v2 1/2] extcon: axp288: Add missed error check
It seems from the very beginning the error check has been missed
in axp288_extcon_log_rsi(). Add it here.
Cc: Ramakrishna Pallala <ramakrishna.pallala@...el.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
---
- added error message (Chanwoo)
drivers/extcon/extcon-axp288.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c
index 7254852e6ec0..694a8d4a57ff 100644
--- a/drivers/extcon/extcon-axp288.c
+++ b/drivers/extcon/extcon-axp288.c
@@ -135,6 +135,11 @@ static void axp288_extcon_log_rsi(struct axp288_extcon_info *info)
int ret;
ret = regmap_read(info->regmap, AXP288_PS_BOOT_REASON_REG, &val);
+ if (ret < 0) {
+ dev_err(info->dev, "failed to read reset source indicator\n");
+ return;
+ }
+
for (i = 0, rsi = axp288_pwr_up_down_info; *rsi; rsi++, i++) {
if (val & BIT(i)) {
dev_dbg(info->dev, "%s\n", *rsi);
--
2.20.1
Powered by blists - more mailing lists