linux-kernel - Re: [PATCH v2] drm/panel: check failure cases in the probe func

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190726123353.GA16964@ravnborg.org>
Date:   Fri, 26 Jul 2019 14:33:53 +0200
From:   Sam Ravnborg <sam@...nborg.org>
To:     Navid Emamdoost <navid.emamdoost@...il.com>
Cc:     secalert@...hat.com, David Airlie <airlied@...ux.ie>, kjlu@....edu,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        Thierry Reding <thierry.reding@...il.com>, smccaman@....edu,
        emamd001@....edu
Subject: Re: [PATCH v2] drm/panel: check failure cases in the probe func

Hi Navid.

On Wed, Jul 24, 2019 at 02:55:34PM -0500, Navid Emamdoost wrote:
> The following function calls may fail and return NULL, so the null check
> is added.
> of_graph_get_next_endpoint
> of_graph_get_remote_port_parent
> of_graph_get_remote_port
> 
> Update: Thanks to Sam Ravnborg, for suggession on the use of goto to avoid
> leaking endpoint.
> 
> Signed-off-by: Navid Emamdoost <navid.emamdoost@...il.com>
Applied and pushed to drm-misc-next.

	Sam